fix: resolve 15 frontend and backend review issues#12
Merged
Conversation
Frontend (high priority): - Dark mode toggle now uses custom theme instead of generic visuals - Mini mode only sends resize command once, not every frame - Repaint rate reduced to 0.5fps when engine is idle (saves CPU/battery) - ScrollArea wraps main panel to prevent content overflow - EQ/output filter/echo cancel toggles now update running engine Frontend (medium priority): - Spectrum send skips clone when channel is full - pactl poll interval increased from 2s to 5s - Wizard device lists no longer cloned every frame - Auto-save dirty config every 5s to prevent crash data loss - Removed duplicate docstring on render_volume_meter Backend: - OutputFilterEngine suppression_strength uses atomic for live updates - LV2 plugin validates 48kHz sample rate on init - Audio thread busy-wait replaced with yield_now + continue - Improved unsafe Send safety comment to follow Rust conventions - Jitter measurement uses EWMA instead of max-over-window Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix frame drop: replace yield+continue with retry loop (up to 100 yields) in both AudioEngine and OutputFilterEngine to prevent silent audio frame loss under buffer-full conditions - Fix echo cancel toggle: revert checkbox on engine restart failure so UI matches actual state - Fix output filter toggle: revert checkbox and escalate to log::error when OutputFilterEngine::start fails - Fix jitter measurement: clamp loop_delta to <100ms to ignore system suspend/resume spikes that skew the EWMA Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Replace reference stream .ok() with match to log actual cpal errors - Handle spectrum sender Disconnected by clearing sender to stop wasted clones - Add status message and config revert for output filter failure in start_engine() - Rename jitter_max_us → jitter_ewma_us to match EWMA semantics Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Frontend - High Priority
theme::setup_custom_style()instead of applying a different inline theme (visual regression fix)Frontend - Medium Priority
Vec::clone()when channel is full (avoids wasted allocation on audio thread)Vecallocation)render_volume_meterBackend
suppression_strengthnow uses an atomic, responds to slider changes at runtimethread::yield_now()+ continue (reduces latency spikes)// SAFETY:Rust convention with improved explanationTest plan
cargo check— clean compile across all 5 cratescargo test— all 16 tests pass🤖 Generated with Claude Code